[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v16 03/14] migration: Calculate mbps only during
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v16 03/14] migration: Calculate mbps only during transfer time |
Date: |
Wed, 27 Jun 2018 10:28:59 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
* Juan Quintela (address@hidden) wrote:
> We used to include in this calculation the setup time, but that can be
> quite big in rdma or multifd.
>
> Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/migration.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index e1eaa97df4..d3e6da9bfe 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -2708,6 +2708,7 @@ static void migration_calculate_complete(MigrationState
> *s)
> {
> uint64_t bytes = qemu_ftell(s->to_dst_file);
> int64_t end_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
> + int64_t transfer_time;
>
> s->total_time = end_time - s->start_time;
> if (!s->downtime) {
> @@ -2718,8 +2719,9 @@ static void migration_calculate_complete(MigrationState
> *s)
> s->downtime = end_time - s->downtime_start;
> }
>
> - if (s->total_time) {
> - s->mbps = ((double) bytes * 8.0) / s->total_time / 1000;
> + transfer_time = s->total_time - s->setup_time;
> + if (transfer_time) {
> + s->mbps = ((double) bytes * 8.0) / transfer_time / 1000;
> }
> }
>
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v16 01/14] migration: Create multipage support, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 04/14] migration: Abstract the number of bytes sent, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 03/14] migration: Calculate mbps only during transfer time, Juan Quintela, 2018/06/26
- Re: [Qemu-devel] [PATCH v16 03/14] migration: Calculate mbps only during transfer time,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v16 02/14] migration: Create multifd packet, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 05/14] migration: Add multifd traces for start/end thread, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 06/14] migration: Multifd channels always wait on the sem, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 07/14] migration: Add block where to send/receive packets, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 09/14] migration: Create multifd_bytes ram_counter, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 08/14] migration: Synchronize multifd threads with main thread, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 11/14] migration: Start sending messages, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 12/14] migration: Wait for blocking IO, Juan Quintela, 2018/06/26
- [Qemu-devel] [PATCH v16 13/14] migration: Remove not needed semaphore and quit, Juan Quintela, 2018/06/26