[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] coverity-model: replay data is considered trust
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] coverity-model: replay data is considered trusted |
Date: |
Tue, 26 Jun 2018 10:55:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 26/06/2018 09:27, Markus Armbruster wrote:
>>
>> Minimal fix:
>>
>> diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c
>> index 48b112393b..f987ce53b8 100644
>> --- a/scripts/coverity-model.c
>> +++ b/scripts/coverity-model.c
>> @@ -106,6 +106,7 @@ static int get_keysym(const name2keysym_t *table,
>> /* Replay data is considered trusted. */
>> uint8_t replay_get_byte(void)
>> {
>> + void *replay_file;
>> uint8_t byte = 0;
>> if (replay_file) {
>> uint8_t c;
>>
>> Alternatively, dumb down to:
>>
>> /* Replay data is considered trusted. */
>> uint8_t replay_get_byte(void)
>> {
>> uint8_t byte;
>> return byte;
>> }
>
> I wonder why the online service didn't complain.
Me too. Of course, I should've run cov-make-library myself. Next
time...
> I guess the dumber
> version is more than enough!
I'll post it as a proper patch. Thanks!