Re: [Qemu-devel] [RFC PATCH] docker: Add fedora-xtensa-cross image

[Philippe Mathieu-Daudé]

On 06/22/2018 11:23 AM, Daniel P. Berrangé wrote:
> On Fri, Jun 22, 2018 at 11:02:23AM -0300, Philippe Mathieu-Daudé wrote:
>> As of this commit:
>>
>>   $ xtensa-linux-gnu-as -v
>>   GNU assembler version 2.29.1 (xtensa-linux-gnu) using BFD version version 
>> 2.29.1-1.fc27
>>
>>   $ xtensa-linux-gnu-gcc -v
>>   Target: xtensa-linux-gnu
>>   gcc version 7.2.1 20170915 (Red Hat Cross 7.2.1-1) (GCC)
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>>  tests/docker/dockerfiles/fedora-xtensa-cross.docker | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>  create mode 100644 tests/docker/dockerfiles/fedora-xtensa-cross.docker
>>
>> diff --git a/tests/docker/dockerfiles/fedora-xtensa-cross.docker 
>> b/tests/docker/dockerfiles/fedora-xtensa-cross.docker
>> new file mode 100644
>> index 0000000000..6f9521520c
>> --- /dev/null
>> +++ b/tests/docker/dockerfiles/fedora-xtensa-cross.docker
>> @@ -0,0 +1,7 @@
>> +FROM fedora:latest
> 
> IIRC, we decided using ':latest' is not a good idea because its meaning
> will change over time and lead to inconsistent results for devs. We saw
> this before when patchew reported failure on fedora while developers saw
> nothing, due to patchew having cached a ":latest" image which was different.

I totally agree with you :)

"FROM fedora:28" works.

> 
>> +ENV PACKAGES \
>> +    binutils-xtensa-linux-gnu \
>> +    gcc-xtensa-linux-gnu
>> +
>> +RUN dnf install -y $PACKAGES
>> +RUN rpm -q $PACKAGES | sort > /packages.txt
> 
> 
> Regards,
> Daniel
>