[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] request a revert for "block: Remove deprecated -drive optio
From: |
Christian Borntraeger |
Subject: |
[Qemu-devel] request a revert for "block: Remove deprecated -drive option serial" (was block: Remove deprecated -drive option serial) |
Date: |
Fri, 22 Jun 2018 14:51:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
adding more CC.
On 06/22/2018 01:38 PM, Christian Borntraeger wrote:
>
> On 06/15/2018 04:21 PM, Kevin Wolf wrote:
>> The -drive option serial was deprecated in QEMU 2.10. It's time to
>> remove it.
>>
>> Tests need to be updated to set the serial number with -global instead
>> of using the -drive option.
>
> libvirt 4.5 still creates those (at least on s390x)
>
> <disk type='file' device='disk'>
> <driver name='qemu' type='qcow2' cache='none' io='native' iothread='1'/>
> <source file='/var/lib/libvirt/qemu/image.zhyp137'/>
> <target dev='hda' bus='virtio'/>
> <serial>skel</serial>
> <boot order='1'/>
> <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0000'/>
> </disk>
>
>
> ->
> [...]
> -drive
> file=/var/lib/libvirt/qemu/image.zhyp137,format=qcow2,if=none,id=drive-virtio-disk0,serial=skel,cache=none,aio=native
> -device
> virtio-blk-ccw,iothread=iothread1,scsi=off,devno=fe.0.0000,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1,write-cache=on
>
> [...]
>
> 2018-06-22T11:25:20.946024Z qemu-system-s390x: -drive
> file=/var/lib/libvirt/qemu/image.zhyp137,format=qcow2,if=none,id=drive-virtio-disk0,serial=skel,cache=none,aio=native:
> Block format 'qcow2' does not support the option 'serial'
> 2018-06-22 11:25:21.098+0000: shutting down, reason=failed
>
> So it seems that this breaks s390x.
So what about reverting commit b0083267444a5e0f28391f6c2831a539f878d424
"block: Remove deprecated -drive option serial" and redo the removal in
qemu 3.1 (or 3.2) ?
Even if we fix libvirt today, this is certainly a too short period of
time to get things fixed in the field.
- [Qemu-devel] [PULL 20/26] block: Fix -blockdev / blockdev-add for empty objects and arrays, (continued)
- [Qemu-devel] [PULL 20/26] block: Fix -blockdev / blockdev-add for empty objects and arrays, Kevin Wolf, 2018/06/15
- [Qemu-devel] [PULL 18/26] check-block-qdict: Rename qdict_flatten()'s variables for clarity, Kevin Wolf, 2018/06/15
- [Qemu-devel] [PULL 19/26] check-block-qdict: Cover flattening of empty lists and dictionaries, Kevin Wolf, 2018/06/15
- [Qemu-devel] [PULL 21/26] rbd: New parameter auth-client-required, Kevin Wolf, 2018/06/15
- [Qemu-devel] [PULL 11/26] block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts(), Kevin Wolf, 2018/06/15
- [Qemu-devel] [PULL 23/26] block: Remove deprecated -drive geometry options, Kevin Wolf, 2018/06/15
- [Qemu-devel] [PULL 26/26] block: Remove dead deprecation warning code, Kevin Wolf, 2018/06/15
- [Qemu-devel] [PULL 24/26] block: Remove deprecated -drive option addr, Kevin Wolf, 2018/06/15
- [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Kevin Wolf, 2018/06/15
- Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Christian Borntraeger, 2018/06/22
- Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Kevin Wolf, 2018/06/22
- Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Christian Borntraeger, 2018/06/22
- Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Christian Borntraeger, 2018/06/22
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Daniel P . Berrangé, 2018/06/22
- Re: [Qemu-devel] [PULL 25/26] block: Remove deprecated -drive option serial, Kevin Wolf, 2018/06/22
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Daniel P . Berrangé, 2018/06/22
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Daniel P . Berrangé, 2018/06/25
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Kevin Wolf, 2018/06/25
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Krempa, 2018/06/25