[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] hw/arm/virt: Silence dtc /memory warning
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] hw/arm/virt: Silence dtc /memory warning |
Date: |
Fri, 22 Jun 2018 12:52:48 +0100 |
On 22 June 2018 at 12:48, Auger Eric <address@hidden> wrote:
> Hi Peter,
>
> On 06/22/2018 01:02 PM, Peter Maydell wrote:
>> This removes all nodes named "memory" or "address@hidden", rather than
>> just the ones in the root, right?
>
> correct
>
> Is that definitely what we want to
>> do? The old code only deleted /memory, and the comment implies
>> that we only look in the root.
>>
>> (I'm wondering if there are DTs that use memory nodes for random
>> odd things other than system memory...)
>
> I don't know the exact use case. Removing the exact /address@hidden
> node is simpler and does not require 2/3 I think. So if this is what is
> expected I can stick to that node.
Well, I think we should remove the wildcard /address@hidden, but not
/foo/bar/address@hidden and other things that aren't in the root...
thanks
-- PMM