[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list |
|
Date: |
Thu, 21 Jun 2018 17:22:04 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/21/2018 06:25 AM, Vladimir Sementsov-Ogievskiy wrote:
>>
>
> agree. and this is one more reason to not load bitmaps in inactive mode
> at all. and drop them (after storing) on inactivating.
> I'll make a patch.
Sure. I guess persistent bitmaps that exist when BDRV_O_INACTIVE is set
need to stay around -- it would be strange if they disappeared just
because the bitmap is inactive -- but we need to effectively overwrite
them on reload from disk.
And while the disk is inactive, these bitmaps definitely need to remain
in an enforced readonly state (can't be deleted, renamed, cleared, set,
reset, etc.)
(I guess it would also be an error to try to remove persistence from a
bitmap on an inactive disk too.)
- [Qemu-devel] [PATCH v2 09/10] qapi: add bitmap info, (continued)
- [Qemu-devel] [PATCH v2 09/10] qapi: add bitmap info, John Snow, 2018/06/12
- [Qemu-devel] [PATCH v2 01/10] qcow2/bitmap: remove redundant arguments from bitmap_list_load, John Snow, 2018/06/12
- [Qemu-devel] [PATCH v2 06/10] qcow2/bitmap: load IN_USE bitmaps if disk is RO, John Snow, 2018/06/12
- [Qemu-devel] [PATCH v2 10/10] qcow2/bitmap: add basic bitmaps info, John Snow, 2018/06/12
- [Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list, John Snow, 2018/06/12