[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 5/7] hmp: Add commands for preconfig
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v5 5/7] hmp: Add commands for preconfig |
Date: |
Thu, 21 Jun 2018 12:05:44 +0100 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
* Igor Mammedov (address@hidden) wrote:
> On Wed, 20 Jun 2018 16:39:45 +0100
> "Dr. David Alan Gilbert (git)" <address@hidden> wrote:
>
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > Allow a bunch of the info commands to be used in preconfig.
> >
> > version, chardev, name, uuid,memdev, iothreads
> > Were enabled in QMP in the previous patch from Igor
> >
> > status, hotpluggable_cpus
> > Was enabled in the original allow-preconfig series
> >
> > history
> > is HMP specific
> >
> > qom-tree, numa
> > Don't have a QMP equivalent
> I'm not sure that 'info numa' in current state is useful/or valid
> at preconfig time wrt memory stats (depends on memory devices
> which hasn't created at that moment yet).
> Let's drop it for now from this series.
OK, gone.
> With it dropped:
>
> Reviewed-by: Igor Mammedov <address@hidden>
Thanks.
Dave
> > Also enable the qom commands qom-list and qom-set.
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > ---
> > hmp-commands-info.hx | 11 +++++++++++
> > hmp-commands.hx | 3 +++
> > 2 files changed, 14 insertions(+)
> >
> > diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> > index ddfcd5adcc..874ff07583 100644
> > --- a/hmp-commands-info.hx
> > +++ b/hmp-commands-info.hx
> > @@ -19,6 +19,7 @@ ETEXI
> > .params = "",
> > .help = "show the version of QEMU",
> > .cmd = hmp_info_version,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -47,6 +48,7 @@ ETEXI
> > .params = "",
> > .help = "show the character devices",
> > .cmd = hmp_info_chardev,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -165,6 +167,7 @@ ETEXI
> > .params = "",
> > .help = "show the command line history",
> > .cmd = hmp_info_history,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -315,6 +318,7 @@ ETEXI
> > .params = "",
> > .help = "show NUMA information",
> > .cmd = hmp_info_numa,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -399,6 +403,7 @@ ETEXI
> > .params = "",
> > .help = "show the current VM status (running|paused)",
> > .cmd = hmp_info_status,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -457,6 +462,7 @@ ETEXI
> > .params = "",
> > .help = "show the current VM name",
> > .cmd = hmp_info_name,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -471,6 +477,7 @@ ETEXI
> > .params = "",
> > .help = "show the current VM UUID",
> > .cmd = hmp_info_uuid,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -613,6 +620,7 @@ ETEXI
> > .params = "[path]",
> > .help = "show QOM composition tree",
> > .cmd = hmp_info_qom_tree,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -671,6 +679,7 @@ ETEXI
> > .params = "",
> > .help = "show memory backends",
> > .cmd = hmp_info_memdev,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -699,6 +708,7 @@ ETEXI
> > .params = "",
> > .help = "show iothreads",
> > .cmd = hmp_info_iothreads,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -829,6 +839,7 @@ ETEXI
> > .params = "",
> > .help = "Show information about hotpluggable CPUs",
> > .cmd = hmp_hotpluggable_cpus,
> > + .flags = "p",
> > },
> >
> > STEXI
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index 3094294e5b..4bdf8e2090 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -1828,6 +1828,7 @@ ETEXI
> > .params = "path",
> > .help = "list QOM properties",
> > .cmd = hmp_qom_list,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -1841,6 +1842,7 @@ ETEXI
> > .params = "path property value",
> > .help = "set QOM property",
> > .cmd = hmp_qom_set,
> > + .flags = "p",
> > },
> >
> > STEXI
> > @@ -1855,6 +1857,7 @@ ETEXI
> > .help = "show various information about the system state",
> > .cmd = hmp_info_help,
> > .sub_table = info_cmds,
> > + .flags = "p",
> > },
> >
> > STEXI
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v5 2/7] hmp: Allow help on preconfig commands, (continued)
- [Qemu-devel] [PATCH v5 2/7] hmp: Allow help on preconfig commands, Dr. David Alan Gilbert (git), 2018/06/20
- [Qemu-devel] [PATCH v5 4/7] qmp: Enable a few commands in preconfig state, Dr. David Alan Gilbert (git), 2018/06/20
- [Qemu-devel] [PATCH v5 3/7] hmp: Restrict auto-complete in preconfig, Dr. David Alan Gilbert (git), 2018/06/20
- [Qemu-devel] [PATCH v5 1/7] hmp: Add flag for preconfig commands, Dr. David Alan Gilbert (git), 2018/06/20
- [Qemu-devel] [PATCH v5 7/7] hmp: Allow HMP in preconfig state again, Dr. David Alan Gilbert (git), 2018/06/20
- [Qemu-devel] [PATCH v5 6/7] hmp: add exit_preconfig, Dr. David Alan Gilbert (git), 2018/06/20
- [Qemu-devel] [PATCH v5 5/7] hmp: Add commands for preconfig, Dr. David Alan Gilbert (git), 2018/06/20