qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 08/26] qobject: Move block-specific qdict code to


From: Eric Blake
Subject: Re: [Qemu-devel] [PULL 08/26] qobject: Move block-specific qdict code to block-qdict.c
Date: Tue, 19 Jun 2018 14:29:21 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/15/2018 09:20 AM, Kevin Wolf wrote:
From: Markus Armbruster <address@hidden>

Pure code motion, except for two brace placements and a comment
tweaked to appease checkpatch.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
  qobject/block-qdict.c     | 640 ++++++++++++++++++++++++++++++++++++++++++++
  qobject/qdict.c           | 629 --------------------------------------------
  tests/check-block-qdict.c | 655 ++++++++++++++++++++++++++++++++++++++++++++++
  tests/check-qdict.c       | 642 ---------------------------------------------
  MAINTAINERS               |   2 +
  qobject/Makefile.objs     |   1 +
  tests/Makefile.include    |   4 +
  7 files changed, 1302 insertions(+), 1271 deletions(-)
  create mode 100644 qobject/block-qdict.c
  create mode 100644 tests/check-block-qdict.c

and missing a change to tests/.gitignore, so that tests/check-block-qdict now shows up as an untracked file on an in-tree build.

(We really should follow through with our threat of renaming all the tests to use a consistent suffix-based pattern, as it's much easier to gitignore a suffix than a prefix)

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]