[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 54/56] docker: docker.py adding age check command
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL 54/56] docker: docker.py adding age check command |
Date: |
Tue, 19 Jun 2018 16:44:33 +0100 |
This is useful for querying if an image is too old.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
v7
- use cached info
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 770b22424b..c748c457b9 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -29,6 +29,7 @@ from tarfile import TarFile, TarInfo
from StringIO import StringIO
from shutil import copy, rmtree
from pwd import getpwuid
+from datetime import datetime,timedelta
FILTERED_ENV_NAMES = ['ftp_proxy', 'http_proxy', 'https_proxy']
@@ -187,6 +188,9 @@ class Docker(object):
except subprocess.CalledProcessError:
return None
+ def get_image_creation_time(self, info):
+ return json.loads(info)[0]["Created"]
+
def get_image_dockerfile_checksum(self, tag):
resp = self.inspect_tag(tag)
labels = json.loads(resp)[0]["Config"].get("Labels", {})
@@ -458,11 +462,14 @@ class CheckCommand(SubCommand):
def args(self, parser):
parser.add_argument("tag",
help="Image Tag")
- parser.add_argument("dockerfile",
- help="Dockerfile name")
+ parser.add_argument("dockerfile", default=None,
+ help="Dockerfile name", nargs='?')
+ parser.add_argument("--checktype", choices=["checksum", "age"],
+ default="checksum", help="check type")
+ parser.add_argument("--olderthan", default=60, type=int,
+ help="number of minutes")
def run(self, args, argv):
- dockerfile = open(args.dockerfile, "rb").read()
tag = args.tag
dkr = Docker()
@@ -471,13 +478,32 @@ class CheckCommand(SubCommand):
print("Image does not exist")
return 1
- if dkr.image_matches_dockerfile(tag, dockerfile):
- if not args.quiet:
- print("Image is up to date")
- return 0
- else:
- print("Image needs updating")
- return 1
+ if args.checktype == "checksum":
+ if not args.dockerfile:
+ print("Need a dockerfile for tag:%s" % (tag))
+ return 1
+
+ dockerfile = open(args.dockerfile, "rb").read()
+
+ if dkr.image_matches_dockerfile(tag, dockerfile):
+ if not args.quiet:
+ print("Image is up to date")
+ return 0
+ else:
+ print("Image needs updating")
+ return 1
+ elif args.checktype == "age":
+ timestr = dkr.get_image_creation_time(info).split(".")[0]
+ created = datetime.strptime(timestr, "%Y-%m-%dT%H:%M:%S")
+ past = datetime.now() - timedelta(minutes=args.olderthan)
+ if created < past:
+ print ("Image created @ %s more than %d minutes old" %
+ (timestr, args.olderthan))
+ return 1
+ else:
+ if not args.quiet:
+ print ("Image less than %d minutes old" % (args.olderthan))
+ return 0
def main():
--
2.17.1
- [Qemu-devel] [PULL 39/56] tests/tcg: enable building for mips64, (continued)
- [Qemu-devel] [PULL 39/56] tests/tcg: enable building for mips64, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 55/56] tests/docker/Makefile.include: only force SID to NOCACHE if old, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 48/56] tests/tcg/i386: extend timeout for runcom test, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 52/56] docker: docker.py add check sub-command, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 41/56] docker: move debian-powerpc-cross to sid based build, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 43/56] tests/tcg/Makefile: update to be called from Makefile.target, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 40/56] tests/tcg: enable building for RISCV64, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 38/56] tests/tcg: enable building for sparc64, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 50/56] docker: docker.py use "version" to probe usage, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 49/56] tests: add top-level make dependency for docker builds, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 54/56] docker: docker.py adding age check command,
Alex Bennée <=
- [Qemu-devel] [PULL 35/56] tests/tcg: enable building for HPPA, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 15/56] tests/tcg: enable building for i386, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 26/56] tests/tcg/arm: add fcvt test cases for AArch32/64, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 29/56] tests/docker/Makefile.include: fix mipsel-cross dependancy, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 21/56] tests/tcg/i386/test-i386: fix printf format, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 42/56] tests/tcg: enable building for PowerPC, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 53/56] tests/Makefile: call sub-makes with SKIP_DOCKER_BUILD=1, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 19/56] tests/tcg/x86_64: add Makefile.target, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 31/56] tests/tcg: enable building for s390x, Alex Bennée, 2018/06/19
- [Qemu-devel] [PULL 34/56] tests/tcg/alpha: add Alpha specific tests, Alex Bennée, 2018/06/19