Re: [Qemu-devel] [PATCH v3 03/26] dmabuf: add y0_top, pass it to spice

[Marc-André Lureau]

Hi

On Tue, Jun 19, 2018 at 8:21 AM, Gerd Hoffmann <address@hidden> wrote:
> On Mon, Jun 18, 2018 at 06:17:06PM +0200, Marc-André Lureau wrote:
>> Some scanouts during boot are top-down without this.
>>
>> Signed-off-by: Marc-André Lureau <address@hidden>
>> ---
>>  include/ui/console.h | 1 +
>>  ui/spice-display.c   | 3 ++-
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/ui/console.h b/include/ui/console.h
>> index 981b519dde..fb969caf70 100644
>> --- a/include/ui/console.h
>> +++ b/include/ui/console.h
>> @@ -186,6 +186,7 @@ struct QemuDmaBuf {
>>      uint32_t  stride;
>>      uint32_t  fourcc;
>>      uint32_t  texture;
>> +    bool      y0_top;
>>  };
>>
>>  typedef struct DisplayChangeListenerOps {
>
> Looks incomplete, who sets y0_top?

It is set from VHOST_USER_GPU_DMABUF_SCANOUT code path in the last patch.

In current qemu code base, only vfio/display uses dmabuf API. But the
VFIO query interface doesn't provide or need that detail.




-- 
Marc-André Lureau