[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/26] vhost-user: split vhost_user_read()
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/26] vhost-user: split vhost_user_read() |
Date: |
Tue, 19 Jun 2018 11:01:00 +0200 |
Hi
On Tue, Jun 19, 2018 at 8:23 AM, Gerd Hoffmann <address@hidden> wrote:
>> @@ -237,7 +251,7 @@ static int vhost_user_read(struct vhost_dev *dev,
>> VhostUserMsg *msg)
>> error_report("Failed to read msg header."
>> " Size %d exceeds the maximum %zu.", msg->hdr.size,
>> VHOST_USER_PAYLOAD_SIZE);
>> - goto fail;
>> + return -1;
>
> Hmm? Looks like a pointless indirection ...
Isn't it removed by the patch? :)
>
>> }
>>
>> if (msg->hdr.size) {
>> @@ -247,14 +261,11 @@ static int vhost_user_read(struct vhost_dev *dev,
>> VhostUserMsg *msg)
>> if (r != size) {
>> error_report("Failed to read msg payload."
>> " Read %d instead of %d.", r, msg->hdr.size);
>> - goto fail;
>> + return -1;
>> }
>> }
>>
>> return 0;
>> -
>> -fail:
>> - return -1;
>
> ... if there is nothing to cleanup here.
>
> cheers,
> Gerd
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH v3 04/26] vhost-user: simplify vhost_user_init/vhost_user_cleanup, (continued)
- [Qemu-devel] [PATCH v3 04/26] vhost-user: simplify vhost_user_init/vhost_user_cleanup, Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 05/26] libvhost-user: exit by default on VHOST_USER_NONE, Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 06/26] vhost-user: wrap some read/write with retry handling, Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 09/26] HACK: vhost-user-backend: allow to specify binary to execute, Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 07/26] qio: add qio_channel_command_new_spawn_with_pre_exec(), Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 08/26] Add vhost-user-backend, Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 10/26] vhost-user: split vhost_user_read(), Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 11/26] vhost-user: add vhost_user_input_get_config(), Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 12/26] libvhost-user: export vug_source_new(), Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 13/26] contrib: add vhost-user-input, Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 14/26] Add vhost-user-input-pci, Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 15/26] vhost-user: add vhost_user_gpu_set_socket(), Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 16/26] vhost-user: add vhost_user_gpu_get_num_capsets(), Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 18/26] util: promote qemu_egl_rendernode_open() to libqemuutil, Marc-André Lureau, 2018/06/18
- [Qemu-devel] [PATCH v3 21/26] virtio-gpu: remove unused config_size, Marc-André Lureau, 2018/06/18