[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/12] migration: hold the lock only if it is re
|
From: |
Peter Xu |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/12] migration: hold the lock only if it is really needed |
|
Date: |
Tue, 19 Jun 2018 15:36:50 +0800 |
|
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Mon, Jun 04, 2018 at 05:55:15PM +0800, address@hidden wrote:
> From: Xiao Guangrong <address@hidden>
>
> Try to hold src_page_req_mutex only if the queue is not
> empty
Pure question: how much this patch would help? Basically if you are
running compression tests then I think it means you are with precopy
(since postcopy cannot work with compression yet), then here the lock
has no contention at all.
Regards,
--
Peter Xu
- Re: [Qemu-devel] [PATCH 05/12] migration: show the statistics of compression, (continued)
[Qemu-devel] [PATCH 07/12] migration: hold the lock only if it is really needed, guangrong . xiao, 2018/06/04
- Re: [Qemu-devel] [PATCH 07/12] migration: hold the lock only if it is really needed,
Peter Xu <=
[Qemu-devel] [PATCH 08/12] migration: do not flush_compressed_data at the end of each iteration, guangrong . xiao, 2018/06/04
[Qemu-devel] [PATCH 09/12] ring: introduce lockless ring buffer, guangrong . xiao, 2018/06/04
Re: [Qemu-devel] [PATCH 09/12] ring: introduce lockless ring buffer, Peter Xu, 2018/06/20