qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] ui/cocoa.m: fix absolute mode
Date: Mon, 18 Jun 2018 12:18:50 +0100

On 8 June 2018 at 21:01, John Arbuckle <address@hidden> wrote:
> Fix the cocoa front-end to correctly be able to use absolute mode.
>
> Signed-off-by: John Arbuckle <address@hidden>

This commit message is insufficiently detailed, which makes
it hard to review the patch. When you send patches, please
can you provide commit messages which describe what the
problem is, where the current code gets things wrong and
why the changes fix the issue? It is painful to have to
reverse-engineer your design from your code changes.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]