Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions

[Peter Maydell]

On 17 June 2018 at 19:48, Julia Suvorova <address@hidden> wrote:
> I can make it if you wish.
> In addition, we can simplify following "if" by removing ARM_FEATURE_V6
> since V7M and V8M define V6:
>
>     if (!arm_dc_feature(s, ARM_FEATURE_V7) &&
>         !(arm_dc_feature(s, ARM_FEATURE_V6) &&
>           arm_dc_feature(s, ARM_FEATURE_M))) {
>         goto illegal_op;
>     }
>
> Like this:
>
>     if (!arm_dc_feature(s, ARM_FEATURE_V7) &&
>         !arm_dc_feature(s, ARM_FEATURE_M)) {
>         goto illegal_op;
>     }
>
> What do you think?

Yes; that would be reasonable. I did consider making that
change when I applied the patch, but decided I didn't really
care much either way. So if you want to send a patch for it
that's fine; if you don't, that's also fine.

thanks
-- PMM