Re: [Qemu-devel] [PATCH] hw/isa/smc37c669: Change the parallel I/O base to 378H

[Richard Henderson]

On 06/14/2018 01:39 PM, Philippe Mathieu-Daudé wrote:
> On the Alpha DP264 machine, the Cirrus VGA is I/O mapped
> in the 3C0H-3CFH range, thus I/O base used by the parallel
> device clashes, and since a4cb773928e the VGA is not
> working:
> 
> (qemu) info mtree
> address-space: memory
>   0000000000000000-ffffffffffffffff (prio 0, i/o): system
>     00000801fc000000-00000801fdffffff (prio 0, i/o): pci0-io
>       ...
>       00000801fc0003b4-00000801fc0003b5 (prio 0, i/o): vga
>       00000801fc0003ba-00000801fc0003ba (prio 0, i/o): vga
>       00000801fc0003bc-00000801fc0003c3 (prio 0, i/o): parallel
>                                     ^^^                ^^^^^^^^
>       00000801fc0003c0-00000801fc0003cf (prio 0, i/o): vga
>                    ^^^
>       00000801fc0003d4-00000801fc0003d5 (prio 0, i/o): vga
>       00000801fc0003da-00000801fc0003da (prio 0, i/o): vga
>       ...
> 
> As there is no particular reason to use this base address
> (introduced in 7bea0dd434e), change to 378H which is the
> default on PC machines.
> 
> Reported-by: Emilio G. Cota <address@hidden>
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> RFC: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg04011.html

Reviewed-by: Richard Henderson <address@hidden>
Tested-by: Richard Henderson <address@hidden>

r~