[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH 01/10] file-posix: Forbid trying to change unsup
From: |
Alberto Garcia |
Subject: |
[Qemu-devel] [RFC PATCH 01/10] file-posix: Forbid trying to change unsupported options during reopen |
Date: |
Thu, 14 Jun 2018 18:48:58 +0300 |
The file-posix code is used for the "file", "host_device" and
"host_cdrom" drivers, and it allows reopening images. However the only
option that is actually processed is "x-check-cache-dropped", and
changes in all other options (e.g. "filename") are silently ignored.
While we could allow changing some of the other options, let's keep
things as they are for now but return an error if the user tries to
change any of them.
Signed-off-by: Alberto Garcia <address@hidden>
---
block/file-posix.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 07bb061fe4..1511a4d69d 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -813,8 +813,13 @@ static int raw_reopen_prepare(BDRVReopenState *state,
goto out;
}
- rs->check_cache_dropped = qemu_opt_get_bool(opts, "x-check-cache-dropped",
- s->check_cache_dropped);
+ rs->check_cache_dropped =
+ qemu_opt_get_bool_del(opts, "x-check-cache-dropped", false);
+
+ /* This driver's reopen function doesn't currently allow changing
+ * other options, so let's put them back in the original QDict and
+ * bdrv_reopen_prepare() will detect changes and complain. */
+ qemu_opts_to_qdict(opts, state->options);
if (s->type == FTYPE_CD) {
rs->open_flags |= O_NONBLOCK;
--
2.11.0
- [Qemu-devel] [RFC PATCH 00/10] Add a 'x-blockdev-reopen' QMP command, Alberto Garcia, 2018/06/14
- [Qemu-devel] [RFC PATCH 04/10] block: Allow changing 'force-share' on reopen, Alberto Garcia, 2018/06/14
- [Qemu-devel] [RFC PATCH 03/10] block: Allow changing 'detect-zeroes' on reopen, Alberto Garcia, 2018/06/14
- [Qemu-devel] [RFC PATCH 02/10] block: Allow changing 'discard' on reopen, Alberto Garcia, 2018/06/14
- [Qemu-devel] [RFC PATCH 01/10] file-posix: Forbid trying to change unsupported options during reopen,
Alberto Garcia <=
- [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen, Alberto Garcia, 2018/06/14
- Re: [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen, Kevin Wolf, 2018/06/18
- Re: [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen, Alberto Garcia, 2018/06/18
- Re: [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen, Kevin Wolf, 2018/06/18
- Re: [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen, Alberto Garcia, 2018/06/19
- Re: [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen, Kevin Wolf, 2018/06/19
- Re: [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen, Alberto Garcia, 2018/06/19
- Re: [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen, Kevin Wolf, 2018/06/20
- Re: [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen, Alberto Garcia, 2018/06/20
- Re: [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen, Kevin Wolf, 2018/06/21