[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management |
Date: |
Thu, 14 Jun 2018 17:40:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 14/06/2018 10:18, Daniel P. Berrangé wrote:
> I don't think
> the -realtime flag should ever have been introduced, and we certainly
> shouldn't add more stuff under it.
>
> "-realtime" is referring to a very specific use case, while the
> properties listed under it are all general purpose features. Real
> time guests just happen to be one possible use case, but it is
> valid to use them for non-real time guests.
>
> IOW, I think we should just have this as an option under -cpu or
> some other *functionally* named option, not a option named after
> a specific usage scenario.
"-cpu" is certainly wrong for KVM_CAP_X86_DISABLE_EXITS. "-cpu" is a
device option, while this is about host behavior. "-realtime"'s name is
awful, but I still think it's the best place for this option. Maybe we
could call it "-realtime power-mgmt={host|guest}".
A separate issue is whether the same flag should control both
KVM_CAP_X86_DISABLE_EXITS and the monitor/mwait CPUID leaf. Eduardo,
what do you think?
Paolo
- Re: [Qemu-devel] [PATCH v2 1/2] kvm: support -realtime cpu-pm=on|off, (continued)
- Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management, Daniel P . Berrangé, 2018/06/14
- Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management, Eduardo Habkost, 2018/06/14
- Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management, Paolo Bonzini, 2018/06/14
- Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management, Michael S. Tsirkin, 2018/06/15
Re: [Qemu-devel] [PATCH v2 0/2] kvm: x86 CPU power management, Kashyap Chamarthy, 2018/06/22