Re: [Qemu-devel] [PATCH v3 7/9] sm501: Implement i2c part for reading monitor EDID

[BALATON Zoltan]

On Thu, 14 Jun 2018, David Gibson wrote:
> On Thu, Jun 14, 2018 at 02:17:00AM +0200, BALATON Zoltan wrote:
> > Signed-off-by: BALATON Zoltan <address@hidden>
>
> Again needs a commit message expanding on what this is and why it's
> useful.

What else need to be explained apart from that SM501 has an i2c part which 
is used to access EDID info of attached monitor. But this is what the 
commit title already says. This patch implements that so far not emulated 
part of the chip.

> [snip]
> >  static const VMStateDescription vmstate_sm501_sysbus = {
> >      .name = TYPE_SYSBUS_SM501,
> > -    .version_id = 1,
> > -    .minimum_version_id = 1,
> > +    .version_id = 2,
> > +    .minimum_version_id = 2,
> >      .fields = (VMStateField[]) {
> >          VMSTATE_STRUCT(state, SM501SysBusState, 1,
> >                         vmstate_sm501_state, SM501State),
>
> Additionally, since you're changing the migration stream, you need to
> point out that this is not used in any machine types which support
> cross-version migration.

AFAIK it is only used in SH4 and PPC sam460ex.