[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/2] qapi: remove empty flat union branches a
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 2/2] qapi: remove empty flat union branches and types |
|
Date: |
Thu, 14 Jun 2018 09:27:05 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Anton Nefedov <address@hidden> writes:
> Flat unions may now have uncovered branches, so it is possible to get rid
> of empty types defined for that purpose only.
>
> Signed-off-by: Anton Nefedov <address@hidden>
I observe a nice shrinking of generated code:
qapi-doc.texi | 134 -----
qapi-introspect.c | 1124 +++++++++++++++++++++++-------------------------
qapi-types-block-core.c | 26 -
qapi-types-block-core.h | 43 -
qapi-types-crypto.c | 13
qapi-types-crypto.h | 9
qapi-types-misc.c | 13
qapi-types-misc.h | 40 -
qapi-types-net.c | 13
qapi-types-net.h | 10
qapi-types-ui.c | 13
qapi-types-ui.h | 14
qapi-visit-block-core.c | 185 +------
qapi-visit-block-core.h | 6
qapi-visit-core.d | 15
qapi-visit-crypto.c | 38 -
qapi-visit-crypto.h | 3
qapi-visit-misc.c | 71 ---
qapi-visit-misc.h | 3
qapi-visit-net.c | 43 -
qapi-visit-net.h | 3
qapi-visit-ui.c | 45 -
qapi-visit-ui.h | 3
23 files changed, 607 insertions(+), 1260 deletions(-)
Reviewed-by: Markus Armbruster <address@hidden>