[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 04/40] checkpatch: Recognize IEC binary prefi
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v4 04/40] checkpatch: Recognize IEC binary prefix definitions |
Date: |
Wed, 13 Jun 2018 16:54:44 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/10/2018 10:14 PM, Philippe Mathieu-Daudé wrote:
> This fixes:
>
> ERROR: "foo * bar" should be "foo *bar"
> #310: FILE: hw/ppc/ppc440_uc.c:564:
> + size = 8 * MiB * sh;
> total: 1 errors, 0 warnings, 433 lines checked
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index e3d8c2cdfc..4923674c71 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -322,6 +322,7 @@ sub build_types {
> (?:${all}\b)
> )
> (?:\s+$Modifier|\s+const)*
> + (?:[KMGTPE]iB)
> }x;
> $Type = qr{
> $NonptrType
>
Well this patch doesn't work like expected...
$ git diff --cached | \
scripts/checkpatch.pl --no-signoff --debug values=2 -
<E> <E> <_>WS( )
<E> <E> <_>IDENT(size)
<E> <V> <_>WS( )
<E> <V> <_>ASSIGN(=)
<E> <N> <_>WS( )
<E> <N> <_>IDENT(8)
<E> <V> <_>WS( )
<E> <V> <_>OPV(*)
<E> <N> <_>WS( )
<E> <N> <_>DECLARE(MiB * ) <------------
<E> <T> <_>IDENT(sh)
<E> <V> <_>END(;)
<E> <E> <_>WS(
)
22 > . size = 8 * MiB * sh;
22 > EEEEEEEEEEVVVVVNNVVNNTTTTTTVVEE
22 > __________________B___________
Which looks OK, but then (example):
$ git diff --cached
diff --git a/include/net/net.h b/include/net/net.h
-void qemu_del_nic(NICState *nic);
+void qemu_del_nic(NICState *test);
$ git diff --cached | \
scripts/checkpatch.pl --no-signoff --debug values=2 -
void qemu_del_nic(NICState *test);
<E> <E> <_>WS( )
<E> <E> <_>IDENT(void)
<E> <V> <_>WS( )
<E> <V> <_>FUNC(qemu_del_nic)
<E> <V> <V>PAREN('(')
<EV> <N> <_>IDENT(NICState)
<EV> <V> <_>WS( )
<EV> <V> <_>OPV(*)
<EV> <N> <_>IDENT(test)
<EV> <V> <_>PAREN(')') -> V
<E> <V> <_>END(;)
<E> <E> <_>WS(
)
10 > . void qemu_del_nic(NICState *test);
10 > EEVVVVVVVVVVVVVVVVVNVVVVVVVVVNVVVVVEE
10 > ____________________________B_______
ERROR: spaces required around that '*' (ctx:WxV)
#10: FILE: include/net/net.h:136:
+void qemu_del_nic(NICState *test);
^
- [Qemu-devel] [PATCH v4 00/40] Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 01/40] include: Add IEC binary prefixes in "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 02/40] vdi: Use definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 03/40] x86/cpu: Use definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 04/40] checkpatch: Recognize IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- Re: [Qemu-devel] [PATCH v4 04/40] checkpatch: Recognize IEC binary prefix definitions,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v4 05/40] hw: Use IEC binary prefix definitions from "qemu/units.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 06/40] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h", Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 07/40] hw/ivshmem: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 08/40] hw/ipack: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 09/40] hw/scsi: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 10/40] hw/smbios: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10