[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/5] Acceptance tests: add Linux kernel boot
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 5/5] Acceptance tests: add Linux kernel boot and console checking test |
|
Date: |
Wed, 13 Jun 2018 15:41:47 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/13/2018 03:30 PM, Eduardo Habkost wrote:
> On Wed, May 30, 2018 at 05:57:52PM -0300, Philippe Mathieu-Daudé wrote:
> [...]
>>> +class BootLinuxConsole(Test):
>>> + """
>>> + Boots a x86_64 Linux kernel and checks that the console is operational
>>> + and the kernel command line is properly passed from QEMU to the kernel
>>> +
>>> + :avocado: enable
>>> + :avocado: tags=x86_64
>>
>> Can you move tags=x86_64 to the test() method?
>
> I'm queueing this patch as is, as the tag here seems harmless. A
> follow-up patch will be required if you want to move the tag.
No problem!