[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 7/8] file-posix: account discard operations
From: |
Anton Nefedov |
Subject: |
[Qemu-devel] [PATCH v3 7/8] file-posix: account discard operations |
Date: |
Wed, 13 Jun 2018 20:44:25 +0300 |
This will help to identify how many of the user-issued discard operations
(accounted on a device level) have actually suceeded down on the host file
(even though the numbers will not be exactly the same if non-raw format
driver is used (e.g. qcow2 sending metadata discards)).
Signed-off-by: Anton Nefedov <address@hidden>
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
---
block/file-posix.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 07bb061..4a2e394 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -163,6 +163,11 @@ typedef struct BDRVRawState {
bool has_fallocate;
bool needs_alignment;
bool check_cache_dropped;
+ struct {
+ int64_t discard_nb_ok;
+ int64_t discard_nb_failed;
+ int64_t discard_bytes_ok;
+ } stats;
PRManager *pr_mgr;
} BDRVRawState;
@@ -1533,6 +1538,16 @@ static ssize_t handle_aiocb_discard(RawPosixAIOData
*aiocb)
return ret;
}
+static void raw_account_discard(BDRVRawState *s, uint64_t nbytes, int ret)
+{
+ if (ret) {
+ s->stats.discard_nb_failed++;
+ } else {
+ s->stats.discard_nb_ok++;
+ s->stats.discard_bytes_ok += nbytes;
+ }
+}
+
static int aio_worker(void *arg)
{
RawPosixAIOData *aiocb = arg;
@@ -1569,6 +1584,7 @@ static int aio_worker(void *arg)
break;
case QEMU_AIO_DISCARD:
ret = handle_aiocb_discard(aiocb);
+ raw_account_discard(aiocb->bs->opaque, aiocb->aio_nbytes, ret);
break;
case QEMU_AIO_WRITE_ZEROES:
ret = handle_aiocb_write_zeroes(aiocb);
@@ -2965,8 +2981,9 @@ static coroutine_fn BlockAIOCB
*hdev_aio_pdiscard(BlockDriverState *bs,
BlockCompletionFunc *cb, void *opaque)
{
BDRVRawState *s = bs->opaque;
-
- if (fd_open(bs) < 0) {
+ int ret = fd_open(bs);
+ if (ret < 0) {
+ raw_account_discard(s, bytes, ret);
return NULL;
}
return paio_submit(bs, s->fd, offset, NULL, bytes,
--
2.7.4
- [Qemu-devel] [PATCH v3 0/8] discard blockstats, Anton Nefedov, 2018/06/13
- [Qemu-devel] [PATCH v3 4/8] scsi: store unmap offset and nb_sectors in request struct, Anton Nefedov, 2018/06/13
- [Qemu-devel] [PATCH v3 1/8] qapi: group BlockDeviceStats fields, Anton Nefedov, 2018/06/13
- [Qemu-devel] [PATCH v3 5/8] scsi: move unmap error checking to the complete callback, Anton Nefedov, 2018/06/13
- [Qemu-devel] [PATCH v3 3/8] ide: account UNMAP (TRIM) operations, Anton Nefedov, 2018/06/13
- [Qemu-devel] [PATCH v3 2/8] qapi: add unmap to BlockDeviceStats, Anton Nefedov, 2018/06/13
- [Qemu-devel] [PATCH v3 6/8] scsi: account unmap operations, Anton Nefedov, 2018/06/13
- [Qemu-devel] [PATCH v3 8/8] qapi: query-blockstat: add driver specific file-posix stats, Anton Nefedov, 2018/06/13
- [Qemu-devel] [PATCH v3 7/8] file-posix: account discard operations,
Anton Nefedov <=
- Re: [Qemu-devel] [PATCH v3 0/8] discard blockstats, no-reply, 2018/06/13
- Re: [Qemu-devel] [PATCH v3 0/8] discard blockstats, no-reply, 2018/06/13