[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] cputlb: Pass cpu_transaction_failed() the c
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] cputlb: Pass cpu_transaction_failed() the correct physaddr |
Date: |
Tue, 12 Jun 2018 12:11:26 -1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/11/2018 02:56 AM, Peter Maydell wrote:
> The API for cpu_transaction_failed() says that it takes the physical
> address for the failed transaction. However we were actually passing
> it the offset within the target MemoryRegion. We don't currently
> have any target CPU implementations of this hook that require the
> physical address; fix this bug so we don't get confused if we ever
> do add one.
>
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> include/exec/exec-all.h | 13 ++++++++++--
> accel/tcg/cputlb.c | 44 +++++++++++++++++++++++++++++------------
> exec.c | 5 +++--
> 3 files changed, 45 insertions(+), 17 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 0/2] cputlb: document iotlb.addr, fix txfail physaddr, Peter Maydell, 2018/06/11
- [Qemu-devel] [PATCH 2/2] cputlb: Pass cpu_transaction_failed() the correct physaddr, Peter Maydell, 2018/06/11
- Re: [Qemu-devel] [PATCH 2/2] cputlb: Pass cpu_transaction_failed() the correct physaddr,
Richard Henderson <=
- [Qemu-devel] [PATCH 1/2] cpu-defs.h: Document CPUIOTLBEntry 'addr' field, Peter Maydell, 2018/06/11
- Re: [Qemu-devel] [PATCH 0/2] cputlb: document iotlb.addr, fix txfail physaddr, Paolo Bonzini, 2018/06/11
- Re: [Qemu-devel] [PATCH 0/2] cputlb: document iotlb.addr, fix txfail physaddr, Peter Maydell, 2018/06/15