Re: [Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication

[Kevin Wolf]

Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben:
> PATCH 01-17 are configuration fixes and cleanup, in particular
> -blockdev driver=nfs,... and -drive driver=(nbd|sheepdog|ssh),... with
> non-string scalars.
> 
> PATCH 18-19 provide support for configuring rbd authentication.
> 
> I'm happy to split the series if that helps.
> 
> Since the RFC post, I amended the documentation of the rbd
> authentication parameters, and squashed PATCH 04 into 03.
> 
> Jeff Cody tested the RFC on his Ceph rig.  All results match
> expectations.
> 
> The series clashes with Max's "[PATCH 00/13] block: Try to create well
> typed json:{} filenames", but Max has rebased his work on mine.

I had minor, but still non-trivial comments for patches 9 and 12. The
rest is:

Reviewed-by: Kevin Wolf <address@hidden>