[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 09/19] linux-user: Propagate goto unimplement
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v3 09/19] linux-user: Propagate goto unimplemented_nowarn to return |
Date: |
Tue, 12 Jun 2018 13:28:30 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/11/2018 09:51 PM, Richard Henderson wrote:
> Reviewed-by: Laurent Vivier <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> linux-user/syscall.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a6b8268332..06205d3d65 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -11807,7 +11807,7 @@ static abi_long do_syscall1(void *cpu_env, int num,
> abi_long arg1,
> return 0;
> }
> #else
> - goto unimplemented_nowarn;
> + return -TARGET_ENOSYS;
> #endif
> #endif
> #ifdef TARGET_NR_get_thread_area
> @@ -11820,12 +11820,12 @@ static abi_long do_syscall1(void *cpu_env, int num,
> abi_long arg1,
> return ts->tp_value;
> }
> #else
> - goto unimplemented_nowarn;
> + return -TARGET_ENOSYS;
> #endif
> #endif
> #ifdef TARGET_NR_getdomainname
> case TARGET_NR_getdomainname:
> - goto unimplemented_nowarn;
> + return -TARGET_ENOSYS;
> #endif
>
> #ifdef TARGET_NR_clock_settime
> @@ -11910,7 +11910,7 @@ static abi_long do_syscall1(void *cpu_env, int num,
> abi_long arg1,
> * holding a mutex that is shared with another process via
> * shared memory).
> */
> - goto unimplemented_nowarn;
> + return -TARGET_ENOSYS;
> #endif
>
> #if defined(TARGET_NR_utimensat)
> @@ -12564,9 +12564,6 @@ static abi_long do_syscall1(void *cpu_env, int num,
> abi_long arg1,
> default:
> unimplemented:
> gemu_log("qemu: Unsupported syscall: %d\n", num);
> -#if defined(TARGET_NR_setxattr) || defined(TARGET_NR_get_thread_area) ||
> defined(TARGET_NR_getdomainname) || defined(TARGET_NR_set_robust_list)
> - unimplemented_nowarn:
> -#endif
> return -TARGET_ENOSYS;
> }
> fail:
>
- [Qemu-devel] [PATCH v3 00/19] linux-user: Split do_syscall, Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 01/19] linux-user/alpha: Fix epoll syscalls, Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 02/19] linux-user/hppa: Fix typo in mknodat syscall, Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 03/19] linux-user/microblaze: Fix typo in accept4 syscall, Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 04/19] linux-user/sparc64: Add inotify_rm_watch and tee syscalls, Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 05/19] linux-user: Remove DEBUG, Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 06/19] linux-user: Split out do_syscall1, Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 09/19] linux-user: Propagate goto unimplemented_nowarn to return, Richard Henderson, 2018/06/11
- Re: [Qemu-devel] [PATCH v3 09/19] linux-user: Propagate goto unimplemented_nowarn to return,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v3 10/19] linux-user: Propagate goto unimplemented to default, Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 08/19] linux-user: Propagate goto efault to return, Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 11/19] linux-user: Propagate goto fail to return, Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 07/19] linux-user: Relax single exit from "break", Richard Henderson, 2018/06/11
- [Qemu-devel] [PATCH v3 12/19] linux-user: Setup split syscall infrastructure, Richard Henderson, 2018/06/11