[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/10] qapi: Formalize qcow2 encryption probi
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/10] qapi: Formalize qcow2 encryption probing |
Date: |
Mon, 11 Jun 2018 23:05:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 2018-06-11 23:02, Eric Blake wrote:
> On 06/11/2018 03:51 PM, Max Reitz wrote:
>> Currently, you can give no encryption format for a qcow2 file while
>> still passing a key-secret. That does not conform to the schema, so
>> this patch changes the schema to allow it.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> qapi/block-core.json | 44 ++++++++++++++++++++++++++++++++++++++++----
>> block/qcow2.c | 3 +++
>> 2 files changed, 43 insertions(+), 4 deletions(-)
>
>> +##
>> +# @ImageInfoSpecificQCow2EncryptionNoInfo:
>> +#
>> +# Only used for the qcow2 encryption format "auto" in which the actual
>> +# encryption format is determined from the image header. Therefore,
>> +# this encryption format will never be reported in
>> +# ImageInfoSpecificQCow2Encryption.
>> +#
>> +# Since: 3.0
>> +##
>> +{ 'struct': 'ImageInfoSpecificQCow2EncryptionNoInfo',
>> + 'data': { } }
>
> Do we actually need this type, given Anton's work on making omitted
> branches automatically use an empty struct?
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg06836.html
Looks like no, we don't. Great! :-)
I think I'll still keep part of the comment and move it down into the
description of ImageInfoSpecificQCow2Encryption so that anyone who's
wondering knows that this value won't appear.
Thanks for reviewing and pointing me at it,
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/10] block: Try to create well typed json:{} filenames, Max Reitz, 2018/06/11
- [Qemu-devel] [PATCH v2 02/10] docs/qapi: Document optional discriminators, Max Reitz, 2018/06/11
- [Qemu-devel] [PATCH v2 01/10] qapi: Add default-variant for flat unions, Max Reitz, 2018/06/11
- [Qemu-devel] [PATCH v2 03/10] tests: Add QAPI optional discriminator tests, Max Reitz, 2018/06/11
- [Qemu-devel] [PATCH v2 04/10] qapi: Formalize qcow2 encryption probing, Max Reitz, 2018/06/11
- [Qemu-devel] [PATCH v2 05/10] qapi: Formalize qcow encryption probing, Max Reitz, 2018/06/11
- [Qemu-devel] [PATCH v2 06/10] qdict: Make qdict_flatten() shallow-clone-friendly, Max Reitz, 2018/06/11
- [Qemu-devel] [PATCH v2 07/10] tests: Add QDict clone-flatten test, Max Reitz, 2018/06/11
- [Qemu-devel] [PATCH v2 08/10] block: Try to create well typed json:{} filenames, Max Reitz, 2018/06/11
- [Qemu-devel] [PATCH v2 09/10] iotests: Test internal option typing, Max Reitz, 2018/06/11