Re: [Qemu-devel] [PATCH 0/3] Add ldn_*_p() and stn_*_p() and use them in exec.c

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/3] Add ldn_*_p() and stn_*_p() and use them in 
exec.c

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
4403b4fdb8 exec.c: Use stn_p() and ldn_p() instead of explicit switches
84ec9af193 exec.c: Don't accidentally sign-extend 4-byte loads in subpage_read()
f01e5dd7b4 bswap: Add new stn_*_p() and ldn_*_p() memory access functions

=== OUTPUT BEGIN ===
Checking PATCH 1/3: bswap: Add new stn_*_p() and ldn_*_p() memory access 
functions...
ERROR: Macros with complex values should be enclosed in parenthesis
#55: FILE: include/exec/cpu-all.h:136:
+#define ldn_p(p, sz ldn_be_p(p, sz)

total: 1 errors, 0 warnings, 104 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/3: exec.c: Don't accidentally sign-extend 4-byte loads in 
subpage_read()...
Checking PATCH 3/3: exec.c: Use stn_p() and ldn_p() instead of explicit 
switches...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden