qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v10 5/7] monitor: remove event_clock_type


From: Peter Xu
Subject: Re: [Qemu-devel] [PATCH v10 5/7] monitor: remove event_clock_type
Date: Mon, 11 Jun 2018 10:42:01 +0800
User-agent: Mutt/1.9.5 (2018-04-13)

On Fri, Jun 08, 2018 at 09:09:57AM +0200, Markus Armbruster wrote:
> Peter Xu <address@hidden> writes:
> 
> > On Fri, Jun 08, 2018 at 07:38:11AM +0200, Markus Armbruster wrote:
> >
> > [...]
> >
> >> > +/*
> >> > + * This should never be called before configure_accelerator() since
> >> > + * only until then could we know whether qtest was enabled or not.
> >> 
> >> Uh, we know it after then, not until then.  What about
> >> 
> >>    /*
> >>     * Return the clock to use for recording an event's time.
> >>     * Beware: result is invalid before configure_accelerator().
> >
> > Oh, another Chinglish from me. :(
> 
> Useful code, occasional Chinglish, the humility to go with it, and a
> sense of humor --- you're doing fine.

Very high evaluation. Thank you. :)

-- 
Peter Xu



reply via email to

[Prev in Thread] Current Thread [Next in Thread]