Re: [Qemu-devel] [PATCH v2 001/108] linux-user: Remove DEBUG

[Philippe Mathieu-Daudé]

On 06/10/2018 12:00 AM, Richard Henderson wrote:
> This is redundant with both -strace and actual tracing.
> 
> Signed-off-by: Richard Henderson <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  linux-user/syscall.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 7b9ac3b408..c212149245 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -163,7 +163,6 @@
>   * (The one remaining unallocated bit is 0x1000 which used to be CLONE_PID.)
>   */
>  
> -//#define DEBUG
>  /* Define DEBUG_ERESTARTSYS to force every syscall to be restarted
>   * once. This exercises the codepaths for restart.
>   */
> @@ -5777,9 +5776,6 @@ static abi_long do_ioctl(int fd, int cmd, abi_long arg)
>          ie++;
>      }
>      arg_type = ie->arg_type;
> -#if defined(DEBUG)
> -    gemu_log("ioctl: cmd=0x%04lx (%s)\n", (long)cmd, ie->name);
> -#endif
>      if (ie->do_ioctl) {
>          return ie->do_ioctl(ie, buf_temp, fd, cmd, arg);
>      } else if (!ie->host_cmd) {
> @@ -7980,9 +7976,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long 
> arg1,
>      }
>  #endif
>  
> -#ifdef DEBUG
> -    gemu_log("syscall %d", num);
> -#endif
>      trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, 
> arg7, arg8);
>      if(do_strace)
>          print_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6);
> @@ -12772,9 +12765,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long 
> arg1,
>          break;
>      }
>  fail:
> -#ifdef DEBUG
> -    gemu_log(" = " TARGET_ABI_FMT_ld "\n", ret);
> -#endif
>      if(do_strace)
>          print_syscall_ret(num, ret);
>      trace_guest_user_syscall_ret(cpu, num, ret);
>