Re: [Qemu-devel] [PATCH v2] Show values and description when using "qom-list"

[Andreas Färber]

Am 08.06.2018 um 11:41 schrieb Dr. David Alan Gilbert:
> * Andreas Färber (address@hidden) wrote:
>> Am 01.06.2018 um 17:39 schrieb Ricardo Perez Blanco:
>>> For debugging purposes it is very useful to:
>>>  - See the description of the field. This information is already filled
>>>    in but not shown in "qom-list" command.
>>
>> No objection on this part.
>>
>>>  - Display value of the field.
>>
>> That is by definition the qom-get operation, not qom-list. Just like the
>> ls command does not show file contents, there's cat etc. for that. For
>> debugging purposes we had a qom-tree (?) command that would combine
>> both.
> 
> I'm not too bothered about distinguishing between the two commands;
> but it would be nice - one reason I'm not too bothered is because we've
> failed to get a qom-get in multiple years of trying.
> 
> 
>>       There might be unmerged patches on qemu-devel related to display
>> of certain data types.
> 
> Which ones?

My original qom-info series needed StringOutputVisitor changes for enums
(test case: rtc) that did not get accepted immediately and thus some
part of HMP qom-info/qom-get got stuck due to risking assertions for
qom-info / otherwise; QMP was not affected IIRC.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)