qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer
Date: Fri, 8 Jun 2018 11:37:36 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

Cc'ing Eric

On 06/08/2018 11:30 AM, Eduardo Habkost wrote:
> All of the supported build platforms documented in qemu-doc.texi
> should already support Python 2.7.

https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg05173.html

  On 08/25/2017 11:40 AM, Peter Maydell wrote:
  > Our choices about our dependencies are generally driven by "what
  > are the versions available on the oldest distros which we wish
  > to support building QEMU on", which typically is whatever the
  > long-term-support versions of Ubuntu, SUSE, Redhat, etc are.
  >
  > Has somebody checked what that means for our Python version
  > requirements?

  At least this one:

  RHEL/CentOS 6: Python-2.6.6

> 
> Removing support for Python 2.6 will allow us to remove some
> compatibility modules we carry in the QEMU tree:
> 
> * scripts/argparse.py
> * scripts/ordereddict.py
> 
> Python 2.6 is also not receiving bug fixes upstream and is not
> supported by pylint, which makes it harder to keep the code
> compatible with both Python 2 and Python 3.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 14b11130a7..a8c4094c87 100755
> --- a/configure
> +++ b/configure
> @@ -1651,8 +1651,8 @@ fi
>  
>  # Note that if the Python conditional here evaluates True we will exit
>  # with status 1 which is a shell 'false' value.
> -if ! $python -c 'import sys; sys.exit(sys.version_info < (2,6))'; then
> -  error_exit "Cannot use '$python', Python 2 >= 2.6 or Python 3 is 
> required." \
> +if ! $python -c 'import sys; sys.exit(sys.version_info < (2,7))'; then
> +  error_exit "Cannot use '$python', Python 2 >= 2.7 or Python 3 is 
> required." \
>        "Use --python=/path/to/python to specify a supported Python."
>  fi
>  
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]