|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check" |
Date: | Fri, 8 Jun 2018 09:24:49 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/07/2018 06:14 PM, Michael S. Tsirkin wrote:
On Thu, Jun 07, 2018 at 04:31:09PM -0600, Ross Zwisler wrote:This commit: commit aa78a16d8645 ("hw/i386: Rename 2.13 machine types to 3.0") updated the name used to create the q35 machine, which in turn changed the SSDT table which is generated when we run "make check": acpi-test: Warning! SSDT mismatch. Actual [asl:/tmp/asl-QZDWJZ.dsl, aml:/tmp/aml-T8JYJZ], Expected [asl:/tmp/asl-DTWVJZ.dsl, aml:tests/acpi-test-data/q35/SSDT.dimmpxm]. Here's the only difference, aside from the checksum: < Name (MEMA, 0x07FFF000) --- > Name (MEMA, 0x07FFE000)Weird. How come the phys address changes just because of machine name?
"2.13" is a different length than "3.0"; depending on whatever other alignment coincidences or sharing of similar substrings are in place, this obviously shuffled enough data that the one byte change then reflects into an entire page boundary difference.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |