[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mism
From: |
Ross Zwisler |
Subject: |
[Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch |
Date: |
Thu, 7 Jun 2018 16:31:08 -0600 |
Currently if "make check" detects a mismatch in the ASL generated during
testing, we print an error such as:
acpi-test: Warning! SSDT mismatch. Actual [asl:/tmp/asl-QZDWJZ.dsl,
aml:/tmp/aml-T8JYJZ], Expected [asl:/tmp/asl-DTWVJZ.dsl,
aml:tests/acpi-test-data/q35/SSDT.dimmpxm].
but the testing still exits with good shell status. This is wrong, and
makes bisecting such a failure difficult.
Signed-off-by: Ross Zwisler <address@hidden>
---
tests/bios-tables-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 256d463cb8..9b5db1ee8f 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -469,6 +469,7 @@ static void test_acpi_asl(test_data *data)
}
}
}
+ g_test_fail();
}
g_string_free(asl, true);
g_string_free(exp_asl, true);
--
2.14.4
- [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files, Ross Zwisler, 2018/06/07
- [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch,
Ross Zwisler <=
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Michael S. Tsirkin, 2018/06/07
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Thomas Huth, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Ross Zwisler, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Michael S. Tsirkin, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Peter Maydell, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Michael S. Tsirkin, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Michael S. Tsirkin, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Peter Maydell, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Michael S. Tsirkin, 2018/06/08
- Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch, Thomas Huth, 2018/06/08