[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig |
Date: |
Thu, 7 Jun 2018 16:28:32 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
* Markus Armbruster (address@hidden) wrote:
> "Dr. David Alan Gilbert" <address@hidden> writes:
>
> > * Markus Armbruster (address@hidden) wrote:
> >> Peter Xu <address@hidden> writes:
> >>
> >> > On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git)
> >> > wrote:
> >> >> From: "Dr. David Alan Gilbert" <address@hidden>
> >> >>
> >> >> Allow a bunch of the info commands to be used in preconfig.
> >> >> Could probably add most of them.
> >> >
> >> > I guess some of them may not work yet during preconfig. E.g.:
> >> >
> >> > $ ./x86_64-softmmu/qemu-system-x86_64 -preconfig -monitor stdio
> >> > QEMU 2.12.50 monitor - type 'help' for more information
> >> > (qemu) info mtree
> >> > address-space: memory
> >> > 0000000000000000-ffffffffffffffff (prio 0, i/o): system
> >> >
> >> > address-space: I/O
> >> > 0000000000000000-000000000000ffff (prio 0, i/o): io
> >> >
> >> > But it's fine to enable that I guess.
> >> >
> >> > (Which "info" command would you want to use during preconfig?)
> >> >
> >> >>
> >> >> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> >> >
> >> > Reviewed-by: Peter Xu <address@hidden>
> >>
> >> The reason for having -preconfig is us despairing of making -S do the
> >> right thing. We'd have to *understand* the tangled mess that is our
> >> startup, and rearrange it so QMP becomes available early enough for
> >> configuring NUMA (and other things), yet late enough for everything to
> >> work.
> >>
> >> -preconfig is a cheap hack to avoid this headache, by bypassing almost
> >> all of "everything".
> >>
> >> Now you bring back some of "everything". Dangerous. You better show it
> >> actually works. Until you do:
> >>
> >> NAK
> >
> > Well I did test each command in here to make sure it didn't
> > crash/produce complete junk; but here's the output with the v2 of this
> > patch that Igor R-b:
> [...]
>
> For the sake of the argument, let's assume these commands all work in
> preconfig state. Are their QMP equivalents all available in preconfig
> state?
That I don't know; I was happy to fix my list to the ones
Igor recommended. If you object to some particular entries I'll
be happy to change them.
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH 1/6] hmp: Add flag for preconfig commands, (continued)
- [Qemu-devel] [PATCH 3/6] hmp: Restrict auto-complete in preconfig, Dr. David Alan Gilbert (git), 2018/06/05
- [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert (git), 2018/06/05
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Peter Xu, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig,
Dr. David Alan Gilbert <=
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Igor Mammedov, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Igor Mammedov, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/08
Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Igor Mammedov, 2018/06/07
[Qemu-devel] [PATCH 5/6] hmp: add exit_preconfig, Dr. David Alan Gilbert (git), 2018/06/05