Re: [Qemu-devel] [PATCH V6 7/7] migration/ram: ensure write persistence on loading all data to PMEM.

[Dr. David Alan Gilbert]

* Stefan Hajnoczi (address@hidden) wrote:
> On Fri, Jun 01, 2018 at 04:10:29PM +0800, address@hidden wrote:
> > diff --git a/migration/ram.c b/migration/ram.c
> > index aa0c6f0..09525b2 100644
> > --- a/migration/ram.c
> > +++ b/migration/ram.c
> > @@ -33,6 +33,7 @@
> >  #include "qemu/bitops.h"
> >  #include "qemu/bitmap.h"
> >  #include "qemu/main-loop.h"
> > +#include "qemu/pmem.h"
> >  #include "xbzrle.h"
> >  #include "ram.h"
> >  #include "migration.h"
> > @@ -3046,6 +3047,13 @@ static int ram_load_setup(QEMUFile *f, void *opaque)
> >  static int ram_load_cleanup(void *opaque)
> >  {
> >      RAMBlock *rb;
> > +
> > +    RAMBLOCK_FOREACH(rb) {
> > +        if (ramblock_is_pmem(rb)) {
> > +            pmem_persist(rb->host, rb->used_length);
> > +         }
> 
> Indentation is off.  This can be fixed by the maintainer who merges
> these patches.
> 
> Reviewed-by: Stefan Hajnoczi <address@hidden>


The other thing that needs a fixup for is RAMBLOCK_FOREACH_MIGRATABLE
that recently got merged.

Dave

--
Dr. David Alan Gilbert / address@hidden / Manchester, UK