[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Bug 1775366] Re: [Feature request] qemu-ga - Allow unexpec
From: |
John Snow |
Subject: |
[Qemu-devel] [Bug 1775366] Re: [Feature request] qemu-ga - Allow unexpected parameter |
Date: |
Wed, 06 Jun 2018 19:40:43 -0000 |
This sounds an awful lot like your hosting provider expects you to be
using a specialized version of qemu-ga which you are not using.
It is my opinion that it's dangerous for a client to accept partial
commands and try to execute them anyway, as those ignored parameters
drastically change the semantics of various commands.
We don't know what we don't know, so this doesn't sound safe.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1775366
Title:
[Feature request] qemu-ga - Allow unexpected parameter
Status in QEMU:
New
Bug description:
It whould be nice if the qemu-ga allowed received messages to contain
fields which is not part of the spec. In my example I have a host
which sends the following request:
{"execute":"guest-exec","arguments":{"path":"prl_nettool","capture-
output":true,"execute-in-shell":false,"arg":[...]}}
Right now this request is rejected with the following error:
{"error": {"class": "GenericError", "desc": "Parameter 'execute-in-
shell' is unexpected"}}
My situation is the hosting provider I use does have some customized
solution which sends some extra arguments. I have manually patched my
qemu-ga so it accepts the "execute-in-shell" parameter but I don't
think this should be necessary.
Instead of "Error" it should just be a "warning" returned to the user
of qemu-ga but the call should still be executed.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1775366/+subscriptions