[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: ignore the OS/ABI field
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: ignore the OS/ABI field |
Date: |
Wed, 6 Jun 2018 02:00:07 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: ignore the OS/ABI field
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2873f03f07 qemu-binfmt-conf.sh: ignore the OS/ABI field
=== OUTPUT BEGIN ===
Checking PATCH 1/1: qemu-binfmt-conf.sh: ignore the OS/ABI field...
ERROR: line over 90 characters
#25: FILE: scripts/qemu-binfmt-conf.sh:10:
+i386_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
ERROR: line over 90 characters
#30: FILE: scripts/qemu-binfmt-conf.sh:14:
+i486_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
ERROR: line over 90 characters
#35: FILE: scripts/qemu-binfmt-conf.sh:18:
+alpha_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
ERROR: line over 90 characters
#44: FILE: scripts/qemu-binfmt-conf.sh:30:
+sparc_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'
ERROR: line over 90 characters
#49: FILE: scripts/qemu-binfmt-conf.sh:34:
+sparc32plus_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'
ERROR: line over 90 characters
#58: FILE: scripts/qemu-binfmt-conf.sh:50:
+m68k_mask='\xff\xff\xff\xff\xff\xff\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'
ERROR: line over 90 characters
#67: FILE: scripts/qemu-binfmt-conf.sh:80:
+sh4_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
ERROR: line over 90 characters
#72: FILE: scripts/qemu-binfmt-conf.sh:84:
+sh4eb_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'
ERROR: line over 90 characters
#77: FILE: scripts/qemu-binfmt-conf.sh:88:
+s390x_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'
total: 9 errors, 0 warnings, 57 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden