[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vhost-user-blk: start vhost when guest kicks
|
From: |
Yongji Xie |
|
Subject: |
Re: [Qemu-devel] [PATCH] vhost-user-blk: start vhost when guest kicks |
|
Date: |
Wed, 6 Jun 2018 11:43:34 +0800 |
On 5 June 2018 at 22:23, Michael S. Tsirkin <address@hidden> wrote:
> On Tue, Jun 05, 2018 at 09:56:10PM +0800, Yongji Xie wrote:
>> Some old guests (before commit 7a11370e5: "virtio_blk: enable VQs early")
>> kick virtqueue before setting VIRTIO_CONFIG_S_DRIVER_OK. This would cause
>> that those old guests fail to boot with vhost-user-blk device.
>>
>> To fix it, start vhost when guest kicks instead of waiting for .set_status().
>>
>> Signed-off-by: Yongji Xie <address@hidden>
>> Signed-off-by: Chai Wen <address@hidden>
>> Signed-off-by: Ni Xun <address@hidden>
>
> Can we at least limit this to when virtio 1.0 has not
> been negotiated?
>
OK, I will limit this to when driver is v0.9.x and device is v1.0 so
we don't violate the spec.
Thanks,
Yongji