Re: [Qemu-devel] [PATCH] CODING_STYLE: Define our preferred form for multiline comments

[Cornelia Huck]

On Tue, 5 Jun 2018 10:19:15 +0100
Peter Maydell <address@hidden> wrote:

> On 5 June 2018 at 08:46, Cornelia Huck <address@hidden> wrote:
> > On Tue, 5 Jun 2018 06:33:22 +0200
> > Thomas Huth <address@hidden> wrote:  

> >> Anyway, could we either use that dense format or the kernel-style
> >> multi-lines-comment format, please? Mixing it asymmetrically is just ugly. 
> >>  
> >
> > I'd vote for the kernel style, then.  
> 
> I don't particularly object to the kernel style (though it's not
> how I personally default to writing comments). I just didn't want
> to rule a huge chunk of our existing comments as out-of-standard
> for what I see as a relatively minor divergence in form --
> we do have a lot of no-leading-separate-/* comments. I can live
> with mandating kernel-style if it means we can rule out GNU-form
> and other weirdnesses though :-)

Yes, we should be flexible... as long as it isn't GNU :)

Whatever we end up with, we should take care that we don't get zillions
of "cleanup" patches that don't add value... something like "no need to
change preexisting comments, unless you're touching the code anyway".