qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 00/17] Block layer patches


From: no-reply
Subject: Re: [Qemu-devel] [PULL 00/17] Block layer patches
Date: Wed, 30 May 2018 09:18:34 -0700 (PDT)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/17] Block layer patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
88e058942a block/create: Mark blockdev-create stable
139ec5ed96 qemu-iotests: Rewrite 213 for blockdev-create job
d62e0ba08d qemu-iotests: Rewrite 212 for blockdev-create job
70de2cafaf qemu-iotests: Rewrite 211 for blockdev-create job
4d54cadc55 qemu-iotests: Rewrite 210 for blockdev-create job
53d9bc5bcc qemu-iotests: Rewrite 207 for blockdev-create job
b63d2e6b5d qemu-iotests: Rewrite 206 for blockdev-create job
c23f6e5ca3 qemu-iotests: iotests.py helper for non-file protocols
28c4344887 qemu-iotests: Add VM.run_job()
d753acd0c3 qemu-iotests: Add iotests.img_info_log()
5eec72445e qemu-iotests: Add VM.qmp_log()
9384dd2be8 qemu-iotests: Add VM.get_qmp_events_filtered()
b42f5f7dd4 block/create: Make x-blockdev-create a job
4cbf01e842 job: Add error message for failing jobs
5399bceb2c vhdx: Fix vhdx_co_create() return value
e7e26c08e7 vdi: Fix vdi_co_do_create() return value
b412f757bc qcow2: Fix Coverity warning when calculating the refcount cache size

=== OUTPUT BEGIN ===
Checking PATCH 1/17: qcow2: Fix Coverity warning when calculating the refcount 
cache size...
Checking PATCH 2/17: vdi: Fix vdi_co_do_create() return value...
Checking PATCH 3/17: vhdx: Fix vhdx_co_create() return value...
Checking PATCH 4/17: job: Add error message for failing jobs...
Checking PATCH 5/17: block/create: Make x-blockdev-create a job...
Checking PATCH 6/17: qemu-iotests: Add VM.get_qmp_events_filtered()...
Checking PATCH 7/17: qemu-iotests: Add VM.qmp_log()...
Checking PATCH 8/17: qemu-iotests: Add iotests.img_info_log()...
ERROR: line over 90 characters
#44: FILE: tests/qemu-iotests/iotests.py:227:
+        line = re.sub('uuid: [-a-f0-9]+', 'uuid: 
XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX', line)

total: 1 errors, 0 warnings, 30 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 9/17: qemu-iotests: Add VM.run_job()...
Checking PATCH 10/17: qemu-iotests: iotests.py helper for non-file protocols...
Checking PATCH 11/17: qemu-iotests: Rewrite 206 for blockdev-create job...
Checking PATCH 12/17: qemu-iotests: Rewrite 207 for blockdev-create job...
Checking PATCH 13/17: qemu-iotests: Rewrite 210 for blockdev-create job...
Checking PATCH 14/17: qemu-iotests: Rewrite 211 for blockdev-create job...
Checking PATCH 15/17: qemu-iotests: Rewrite 212 for blockdev-create job...
Checking PATCH 16/17: qemu-iotests: Rewrite 213 for blockdev-create job...
Checking PATCH 17/17: block/create: Mark blockdev-create stable...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]