Re: [Qemu-devel] [PATCH v3 1/5] Add functional/acceptance tests infrastructure

[Stefan Hajnoczi]

On Tue, May 29, 2018 at 03:37:26PM -0400, Cleber Rosa wrote:
> diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
> index 0ca1a2d4b5..5e090c87fb 100644
> --- a/docs/devel/testing.rst
> +++ b/docs/devel/testing.rst
> @@ -484,3 +484,156 @@ supported. To start the fuzzer, run
>  
>  Alternatively, some command different from "qemu-img info" can be tested, by
>  changing the ``-c`` option.
> +
> +Acceptance tests using the Avocado Framework
> +============================================
> +
> +The ``tests/acceptance`` directory hosts functional tests, also known
> +as acceptance level tests.  They're usually higher level, and may
> +interact with external resources and with various guest operating
> +systems.

Can you give more concrete examples of what acceptance tests do?  This
will make it easier for readers to understand where Avocado fits in.

Things that come to mind: checking the behavior of QMP commands and
guest OS commands.

> +To run all tests in the current directory, tagged in a particular way,
> +run:
> +
> +.. code::
> +
> +  avocado run -t <TAG> .

What is TAG?  I guess this identifies a subset of tests to run?

> +QEMUMachine
> +~~~~~~~~~~~
> +
> +The QEMUMachine API should be somewhat familiar to QEMU hackers.  It's
> +used in the Python iotests, device-crash-test and other Python scripts.

This is not useful to someone who isn't a QEMU hacker :).

Please explain that QEMUMachine is a class for controlling a QEMU
instance, including command-line arguments and monitor commands/events.

signature.asc
Description: PGP signature