Re: [Qemu-devel] [PATCH 11/14] qemu-iotests: Rewrite 211 for blockdev-create job

[Max Reitz]

On 2018-05-25 18:33, Kevin Wolf wrote:
> This rewrites the test case 211 to work with the new x-blockdev-create
> job rather than the old synchronous version of the command.
> 
> All of the test cases stay the same as before, but in order to be able
> to implement proper job handling, the test case is rewritten in Python.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/211     | 384 
> ++++++++++++++++++---------------------------
>  tests/qemu-iotests/211.out | 123 ++++++++-------
>  tests/qemu-iotests/group   |   2 +-
>  3 files changed, 227 insertions(+), 282 deletions(-)
> 
> diff --git a/tests/qemu-iotests/211 b/tests/qemu-iotests/211
> index 1edec26517..2fd89cfb32 100755
> --- a/tests/qemu-iotests/211
> +++ b/tests/qemu-iotests/211

[...]
> +    iotests.img_info_log(disk_path)
> +    iotests.log(iotests.filter_testfiles(iotests.qemu_img_pipe(
> +        'map', '--output=json', disk_path)))

The _filter_qemu_img_map wasn't there to filter the filename (it isn't
present in the JSON output anyway, from what I can see), but to filter
the offset.

I don't think we really need to filter the offset here, though, because
this test is for a single specific image format with very specific
options, so it should be OK.

(The only thing is that the filter_testfiles() call seems unnecessary.)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature