[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/20] e1000e: use local path for local heade
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/20] e1000e: use local path for local headers |
Date: |
Fri, 25 May 2018 18:36:32 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/net/e1000e.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c
> index 16a9417..cda8d48 100644
> --- a/hw/net/e1000e.c
> +++ b/hw/net/e1000e.c
> @@ -41,7 +41,7 @@
> #include "hw/pci/msi.h"
> #include "hw/pci/msix.h"
>
> -#include "hw/net/e1000_regs.h"
> +#include "e1000_regs.h"
>
Can you remove this extra newline while here?
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> #include "e1000x_common.h"
> #include "e1000e_core.h"
>
- Re: [Qemu-devel] [PATCH v2 04/20] migration: drop an unused include, (continued)
- [Qemu-devel] [PATCH v2 01/20] block: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 05/20] trace: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 08/20] ioapic: fix up includes, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 09/20] e1000e: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- Re: [Qemu-devel] [PATCH v2 09/20] e1000e: use local path for local headers,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 06/20] display: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 07/20] ide: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 10/20] rocker: drop an unused include, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 11/20] ppc: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 12/20] vhost-scsi: drop an unused include, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 13/20] sd: fix up include, Michael S. Tsirkin, 2018/05/25