[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 18/49] tests/tcg: enable building for i386
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PATCH v5 18/49] tests/tcg: enable building for i386 |
Date: |
Fri, 25 May 2018 14:38:20 +0100 |
While you can construct a compile command that does work using the
x86_64 host compiler that most people use this is flakey. Different
distros handle this is different ways so we default to using a known
good i386 compiler via docker.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
---
v3
- add runner for runcom
v4
- runcom pi10.com directly from SRC_DIR
v5
- define extra test-mmap runs
---
tests/tcg/i386/Makefile.include | 9 +++++++++
tests/tcg/i386/Makefile.target | 7 +++++++
2 files changed, 16 insertions(+)
create mode 100644 tests/tcg/i386/Makefile.include
diff --git a/tests/tcg/i386/Makefile.include b/tests/tcg/i386/Makefile.include
new file mode 100644
index 0000000000..be1c3008dd
--- /dev/null
+++ b/tests/tcg/i386/Makefile.include
@@ -0,0 +1,9 @@
+#
+# Makefile.include for all i386
+#
+# There is enough brokeness in x86_64 compilers that we don't default
+# to using the x86_64 system compiler for i386 binaries.
+#
+
+DOCKER_IMAGE=fedora-i386-cross
+DOCKER_CROSS_COMPILER=gcc
diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target
index 2f27b65e2d..8b46cc021e 100644
--- a/tests/tcg/i386/Makefile.target
+++ b/tests/tcg/i386/Makefile.target
@@ -28,3 +28,10 @@ hello-i386: LDFLAGS+=-nostdlib
test-i386: test-i386.c test-i386-code16.S test-i386-vm86.S test-i386.h
test-i386-shift.h test-i386-muldiv.h
$(CC) $(CFLAGS) $(LDFLAGS) -o $@ \
$(<D)/test-i386.c $(<D)/test-i386-code16.S $(<D)/test-i386-vm86.S -lm
+
+# Specialist test runners
+run-runcom: runcom pi_10.com
+ $(call quiet-command, $(QEMU) ./runcom $(I386_SRC)/pi_10.com >
runcom.out, "TEST", "$< on $(TARGET_NAME)")
+
+# On i386 and x86_64 Linux only supports 4k pages (large pages are a different
hack)
+EXTRA_RUNS+=run-test-mmap-4096
--
2.17.0
- [Qemu-devel] [PATCH v5 05/49] configure: allow user to specify --cross-cc-cflags-foo=, (continued)
- [Qemu-devel] [PATCH v5 05/49] configure: allow user to specify --cross-cc-cflags-foo=, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 04/49] configure: move i386_cc to cross_cc_i386, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 03/49] configure: add support for --cross-cc-FOO, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 08/49] docker: Add "cc" subcommand, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 07/49] Makefile: Rename TARGET_DIRS to TARGET_LIST, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 11/49] docker: Makefile.include introduce DOCKER_SCRIPT, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 10/49] docker: allow "cc" command to run in user context, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 12/49] tests/tcg: move architecture independent tests into subdir, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 16/49] tests/tcg: move i386 specific tests into subdir, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 09/49] docker: extend "cc" command to accept compiler, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 18/49] tests/tcg: enable building for i386,
Alex Bennée <=
- [Qemu-devel] [PATCH v5 15/49] tests/tcg/multiarch: move most output to stdout, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 20/49] tests/tcg/i386: fix test-i386, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 19/49] tests/tcg/i386: Build fix for hello-i386, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 14/49] tests/tcg/multiarch: enable additional linux-test tests, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 13/49] tests/tcg/multiarch: Build fix for linux-test, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 17/49] docker: Add fedora-i386-cross image, Alex Bennée, 2018/05/25
- [Qemu-devel] [PATCH v5 22/49] tests/tcg/x86_64: add Makefile.target, Alex Bennée, 2018/05/25