[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets |
Date: |
Fri, 25 May 2018 10:01:57 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Fri, May 25, 2018 at 11:30:22AM +0800, Peter Xu wrote:
> On Thu, May 24, 2018 at 10:28:37AM +0100, Stefan Hajnoczi wrote:
> > On Thu, May 24, 2018 at 12:39:52PM +0800, Peter Xu wrote:
> > > int monitor_fdset_get_fd(int64_t fdset_id, int flags)
> > > {
> > > -#ifndef _WIN32
> > > +#ifdef _WIN32
> > > + return -ENOENT;
> >
> > stubs/fdset.c:monitor_fdset_get_fd() should return -ENOENT instead of -1
> > now.
>
> Yes that's intended. That's actually a suggestion from Markus since
> changing the return code will simplify the code.
No, I understand that part. I'm pointing out that
stubs/fdset.c:monitor_fdset_get_fd() still returns -1 because it was not
updated by this patch.
Since this patch changes the return value to -errno, the stub function
should be updated to return a sensible -errno value too.
Stefan
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs, (continued)
[Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets, Peter Xu, 2018/05/24
Re: [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe, no-reply, 2018/05/24