[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] gdbstub: Prevent fd leakage
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-devel] [PATCH] gdbstub: Prevent fd leakage |
Date: |
Thu, 24 May 2018 19:34:58 -0300 |
Since 2f652224f7, we now check if socket_set_nodelay() errored,
but forgot to close the socket before reporting an error.
Fixes: Coverity CID 1391290 (RESOURCE_LEAK)
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
gdbstub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdbstub.c b/gdbstub.c
index e4ece2f5bc..9c860cd81c 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1836,6 +1836,7 @@ static bool gdb_accept(void)
/* set short latency */
if (socket_set_nodelay(fd)) {
perror("setsockopt");
+ close(fd);
return false;
}
--
2.17.0
- [Qemu-devel] [PATCH] gdbstub: Prevent fd leakage,
Philippe Mathieu-Daudé <=