qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V3 1/2] arm_gicv3_kvm: increase clroffset accord


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH V3 1/2] arm_gicv3_kvm: increase clroffset accordingly
Date: Thu, 24 May 2018 13:38:47 +0100

On 23 May 2018 at 04:53, Shannon Zhao <address@hidden> wrote:
> It forgot to increase clroffset during the loop. So it only clear the
> first 4 bytes.
>
> Fixes: 367b9f527becdd20ddf116e17a3c0c2bbc486920
> Cc: address@hidden
> Signed-off-by: Shannon Zhao <address@hidden>
> Reviewed-by: Eric Auger <address@hidden>
> ---
> Changes in V3: Add reviewed-by tag
> ---
>  hw/intc/arm_gicv3_kvm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
> index ec37177..3536795 100644
> --- a/hw/intc/arm_gicv3_kvm.c
> +++ b/hw/intc/arm_gicv3_kvm.c
> @@ -243,6 +243,7 @@ static void kvm_dist_putbmp(GICv3State *s, uint32_t 
> offset,
>          if (clroffset != 0) {
>              reg = 0;
>              kvm_gicd_access(s, clroffset, &reg, true);
> +            clroffset += 4;
>          }
>          reg = *gic_bmp_ptr32(bmp, irq);
>          kvm_gicd_access(s, offset, &reg, true);
> --

Applied this patch to target-arm.next.

PS: if you could remember to always provide a cover letter
for multi-patch series that would be helpful.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]