[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free flei
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs |
Date: |
Thu, 24 May 2018 16:49:23 +0800 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Thu, May 24, 2018 at 09:08:04AM +0100, Stefan Hajnoczi wrote:
> On Thu, May 24, 2018 at 12:39:51PM +0800, Peter Xu wrote:
> > Add some explicit comment for both Readline and cpu_set/cpu_get helpers
> > that they do not need the mon_lock protection.
> >
> > Signed-off-by: Peter Xu <address@hidden>
> > ---
> > monitor.c | 12 +++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
>
> Aside from the checkpatch.pl error that needs to be fixed (I like to use
> a git hook to check automatically, see
> http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html):
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
Thanks Stefan. I start to use it now!
--
Peter Xu
[Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets, Peter Xu, 2018/05/24
Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets, Stefan Hajnoczi, 2018/05/24