[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 08/19] replay: introduce info hmp/qmp command
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [PATCH v3 08/19] replay: introduce info hmp/qmp command |
Date: |
Wed, 23 May 2018 09:50:27 +0300 |
User-agent: |
StGit/0.17.1-dirty |
This patch introduces 'info replay' monitor command and
corresponding qmp request.
These commands request the current record/replay mode, replay log file name,
and the execution step (number or recorded/replayed instructions).
Signed-off-by: Pavel Dovgalyuk <address@hidden>
--
v2:
- renamed info_replay qmp into query-replay (suggested by Eric Blake)
---
hmp-commands-info.hx | 14 ++++++++++++++
hmp.h | 1 +
qapi/misc.json | 35 +++++++++++++++++++++++++++++++++++
replay/Makefile.objs | 3 ++-
replay/replay-debugging.c | 41 +++++++++++++++++++++++++++++++++++++++++
replay/replay-internal.h | 2 ++
replay/replay.c | 3 +--
7 files changed, 96 insertions(+), 3 deletions(-)
create mode 100644 replay/replay-debugging.c
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
index ddfcd5a..f5631be 100644
--- a/hmp-commands-info.hx
+++ b/hmp-commands-info.hx
@@ -883,6 +883,20 @@ STEXI
Show SEV information.
ETEXI
+ {
+ .name = "replay",
+ .args_type = "",
+ .params = "",
+ .help = "show parameters of the record/replay",
+ .cmd = hmp_info_replay,
+ },
+
+STEXI
address@hidden info replay
address@hidden info replay
+Display the current record/replay mode and the currently executing step.
+ETEXI
+
STEXI
@end table
ETEXI
diff --git a/hmp.h b/hmp.h
index 20f2743..aeec705 100644
--- a/hmp.h
+++ b/hmp.h
@@ -146,5 +146,6 @@ void hmp_hotpluggable_cpus(Monitor *mon, const QDict
*qdict);
void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict);
void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict);
void hmp_info_sev(Monitor *mon, const QDict *qdict);
+void hmp_info_replay(Monitor *mon, const QDict *qdict);
#endif
diff --git a/qapi/misc.json b/qapi/misc.json
index f5988cc..0fe2df9 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -3098,6 +3098,41 @@
'data': [ 'none', 'record', 'play' ] }
##
+# @ReplayInfo:
+#
+# Status of the record/replay mode.
+#
+# @mode: current mode.
+#
+# @filename: name of the record/replay log file.
+#
+# @step: current step number.
+#
+# Since: 2.13
+#
+##
+{ 'struct': 'ReplayInfo',
+ 'data': { 'mode': 'ReplayMode', '*filename': 'str', 'step': 'int' } }
+
+##
+# @query-replay:
+#
+# Retrieves the status of the execution record/replay.
+#
+# Returns: structure with the properties of the record/replay.
+#
+# Since: 2.13
+#
+# Example:
+#
+# -> { "execute": "query-replay" }
+# <- { "return": { "mode": "play", "filename": "log.rr", "step": 220414 } }
+#
+##
+{ 'command': 'query-replay',
+ 'returns': 'ReplayInfo' }
+
+##
# @xen-load-devices-state:
#
# Load the state of all devices from file. The RAM and the block devices
diff --git a/replay/Makefile.objs b/replay/Makefile.objs
index cee6539..6694e3e 100644
--- a/replay/Makefile.objs
+++ b/replay/Makefile.objs
@@ -6,4 +6,5 @@ common-obj-y += replay-input.o
common-obj-y += replay-char.o
common-obj-y += replay-snapshot.o
common-obj-y += replay-net.o
-common-obj-y += replay-audio.o
\ No newline at end of file
+common-obj-y += replay-audio.o
+common-obj-y += replay-debugging.o
diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c
new file mode 100644
index 0000000..03e7db8
--- /dev/null
+++ b/replay/replay-debugging.c
@@ -0,0 +1,41 @@
+/*
+ * replay-debugging.c
+ *
+ * Copyright (c) 2010-2018 Institute for System Programming
+ * of the Russian Academy of Sciences.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ *
+ */
+
+#include "qemu/osdep.h"
+#include "qapi/error.h"
+#include "sysemu/replay.h"
+#include "replay-internal.h"
+#include "hmp.h"
+#include "monitor/monitor.h"
+#include "qapi/qapi-commands-misc.h"
+
+void hmp_info_replay(Monitor *mon, const QDict *qdict)
+{
+ if (replay_mode == REPLAY_MODE_NONE) {
+ monitor_printf(mon, "No record/replay\n");
+ } else {
+ monitor_printf(mon, "%s execution '%s': current step = %"PRId64"\n",
+ replay_mode == REPLAY_MODE_RECORD ? "Recording" : "Replaying",
+ replay_filename, replay_get_current_step());
+ }
+}
+
+ReplayInfo *qmp_query_replay(Error **errp)
+{
+ ReplayInfo *retval = g_new0(ReplayInfo, 1);
+ retval->mode = replay_mode;
+ if (replay_filename) {
+ retval->filename = g_strdup(replay_filename);
+ retval->has_filename = true;
+ }
+ retval->step = replay_get_current_step();
+ return retval;
+}
diff --git a/replay/replay-internal.h b/replay/replay-internal.h
index ac4b27b..ef82b5e 100644
--- a/replay/replay-internal.h
+++ b/replay/replay-internal.h
@@ -91,6 +91,8 @@ extern ReplayState replay_state;
/* File for replay writing */
extern FILE *replay_file;
+/*! Name of replay file */
+extern char *replay_filename;
void replay_put_byte(uint8_t byte);
void replay_put_event(uint8_t event);
diff --git a/replay/replay.c b/replay/replay.c
index 58a986f..8b70d7d 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -29,8 +29,7 @@
ReplayMode replay_mode = REPLAY_MODE_NONE;
char *replay_snapshot;
-/* Name of replay file */
-static char *replay_filename;
+char *replay_filename;
ReplayState replay_state;
static GSList *replay_blockers;
- [Qemu-devel] [PATCH v3 00/19] reverse debugging, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 01/19] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 02/19] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 03/19] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 04/19] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 05/19] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 06/19] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 07/19] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 08/19] replay: introduce info hmp/qmp command,
Pavel Dovgalyuk <=
- [Qemu-devel] [PATCH v3 09/19] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 10/19] replay: implement replay-seek command to proceed to the desired step, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 11/19] replay: flush events when exiting, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 13/19] replay: refine replay-time module, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 12/19] timer: remove replay clock probe in deadline calculation, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 14/19] translator: fix breakpoint processing, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 15/19] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 16/19] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 17/19] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2018/05/23
- [Qemu-devel] [PATCH v3 18/19] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2018/05/23