[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support |
|
Date: |
Wed, 23 May 2018 08:50:01 +0200 |
|
User-agent: |
NeoMutt/20180512 |
Hi,
> > + if (pci_bus_is_express(pci_get_bus(dev))) {
> > + dev->cap_present |= QEMU_PCI_CAP_EXPRESS;
> > + ret = pcie_endpoint_cap_init(dev, 0x80);
> > + assert(ret > 0);
>
> Maybe error_setg(errp, ...) && return?
No. It really should not trigger, and if it does it is a bug in qemu
and not the user doing something wrong.
cheers,
Gerd
- [Qemu-devel] [PATCH v2 0/6] display: add new bochs-display device, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 6/6] MAINTAINERS: add vga entries, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 5/6] bochs-display: add pcie support, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 2/6] vga-pci: use PCI_VGA_MMIO_SIZE, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 1/6] vga: move bochs vbe defines to header file, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 3/6] hw/display: add new bochs-display device, Gerd Hoffmann, 2018/05/22
- [Qemu-devel] [PATCH v2 4/6] bochs-display: add dirty tracking support, Gerd Hoffmann, 2018/05/22